potiuk opened a new pull request #20744:
URL: https://github.com/apache/airflow/pull/20744


   PIP produces a warning when root user is used to run pip install.
   This is done for a good reason - because installing PIP this way
   clashes with a number of distro-managed python packages.
   
   The advice given by the warning is a bit misleading - it suggests
   to use virtualenv, but since this is considered a bad practice
   for container building and because we need to create virtualenvs
   dynamically inside the image, using virtualenv is a bad solution
   for us. It's been attempted in #19189 and failed.
   
   Instead we create an airflow user and use PIP_USER="true" which
   installs all dependencies in build segment to ~/.local folder
   from where we can copy it to the main image.
   
   That get rids of the warning and at the same time allows us to
   keep the best practices of building the images.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to