ashb commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r780226659



##########
File path: docs/apache-airflow/plugins.rst
##########
@@ -268,6 +285,7 @@ definitions in Airflow.
         operator_extra_links = [
             S3LogLink(),
         ]
+        listeners = [PrintingRunningListener]

Review comment:
       So looking at pytest itself (which is where pluggy came out of) the 
plugins are def just modules, not classes 
https://docs.pytest.org/en/6.2.x/writing_plugins.html
   
   I think we should follow pytest's lead here unless we have a very good 
reason to diverge.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to