kazanzhy commented on a change in pull request #20654:
URL: https://github.com/apache/airflow/pull/20654#discussion_r780476931
##########
File path: airflow/providers/cncf/kubernetes/utils/pod_manager.py
##########
@@ -180,7 +180,7 @@ def follow_container_logs(self, pod: V1Pod, container_name:
str) -> None:
So the looping logic is there to let us resume following the logs.
"""
- def follow_logs(since_time: Optional[datetime] = None) ->
Optional[datetime]:
+ def follow_logs(since_time: Optional[datetime] = None) -> Union[Date,
Time, Duration, datetime, None]:
Review comment:
As `parse_log_line` method return a pendulum object I thought to add
before returning something like
```
if timestamp is not None:
datetime.fromtimestamp(timestamp.timestamp())
```
Then we will have only the `Optional[datetime]` returning type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
