potiuk commented on a change in pull request #20748:
URL: https://github.com/apache/airflow/pull/20748#discussion_r780280882
##########
File path: dev/breeze/src/airflow_breeze/cache.py
##########
@@ -20,10 +20,10 @@
from typing import Any, List, Optional, Tuple
from airflow_breeze import global_constants
-from airflow_breeze.breeze import get_airflow_sources_root
from airflow_breeze.console import console
+from airflow_breeze.global_constants import BUILD_CACHE_DIR
-BUILD_CACHE_DIR = Path(get_airflow_sources_root(), '.build')
+# BUILD_CACHE_DIR = Path(get_airflow_sources_root(), '.build')
Review comment:
Let's just remove it :)
##########
File path: dev/breeze/src/airflow_breeze/global_constants.py
##########
@@ -177,3 +181,41 @@
"POSTGRES_VERSION": "--postgres-version",
"MSSQL_VERSION": "--mssql-version",
}
+
Review comment:
I tihnk we can move those to a separate file. `global_constants` is not
a good place.
maybe `path_utils.py` ? or maybe even we should have "utils" module and move
it to "utils/path_utils.py" ?
Then possibly current "utils.py" could be moved to "utils/run_utils.py"
##########
File path: dev/breeze/src/airflow_breeze/global_constants.py
##########
@@ -177,3 +181,41 @@
"POSTGRES_VERSION": "--postgres-version",
"MSSQL_VERSION": "--mssql-version",
}
+
Review comment:
Just make sure `utils/__init__.py` is there too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
