pierrejeambrun commented on a change in pull request #20386:
URL: https://github.com/apache/airflow/pull/20386#discussion_r780820054
##########
File path: tests/utils/test_process_utils.py
##########
@@ -105,6 +109,20 @@ def test_should_print_all_messages1(self):
assert ["Executing cmd: bash -c 'echo CAT; echo KITTY;'", 'Output:',
'CAT', 'KITTY'] == msgs
+ def test_should_print_all_messages_from_cwd(self):
Review comment:
`unittest.TestCase` are only compatible with `autouse` fixture. I have
changed a little bit the test so I don't need the `self.assertLogs` method.
This way I can remove the extends to `unittest.TestCase` and use normal
fixtures.
Let me know if this is better.
##########
File path: tests/utils/test_process_utils.py
##########
@@ -97,6 +97,10 @@ def test_reap_process_group(self):
class TestExecuteInSubProcess(unittest.TestCase):
+ @pytest.fixture(autouse=True)
+ def _tmp_path(self, tmp_path):
+ self.tmp_path = tmp_path
Review comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
