SamWheating commented on a change in pull request #18590:
URL: https://github.com/apache/airflow/pull/18590#discussion_r780840273
##########
File path: tests/cli/commands/test_user_command.py
##########
@@ -45,18 +48,9 @@ def _set_attrs(self, app, dagbag, parser):
self.dagbag = dagbag
self.parser = parser
self.appbuilder = self.app.appbuilder
- self.clear_roles_and_roles()
+ delete_users(app)
Review comment:
Is this change going to have any side affects on other tests? The two
functions do pretty different things.
`clear_roles_and_roles` (maybe this should have been names
`clear_users_and_roles`?) only deletes the test users and roles used in these
tests
`delete_users` deletes all users (and leaves the roles intact).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
