uranusjr commented on a change in pull request #20743:
URL: https://github.com/apache/airflow/pull/20743#discussion_r780893173
##########
File path: airflow/models/baseoperator.py
##########
@@ -1634,7 +1635,7 @@ def map(self, **kwargs) -> "MappedOperator":
def _validate_kwarg_names_for_mapping(cls: Type[BaseOperator], func_name: str,
value: Dict[str, Any]):
- if isinstance(str, cls):
+ if isinstance(cls, str):
Review comment:
Neither the old and new line seem to make sense? Should `cls` be
annotated as `Union[Type[BaseOperator], str]` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
