potiuk commented on a change in pull request #20677:
URL: https://github.com/apache/airflow/pull/20677#discussion_r780961195
##########
File path: airflow/tracer.py
##########
@@ -0,0 +1,23 @@
+from opentelemetry import trace
+from opentelemetry.instrumentation.flask import FlaskInstrumentor
+from opentelemetry.instrumentation.requests import RequestsInstrumentor
+from opentelemetry.exporter.jaeger.thrift import JaegerExporter
+from opentelemetry.sdk.resources import SERVICE_NAME, Resource
+from opentelemetry.sdk.trace import TracerProvider
+from opentelemetry.sdk.trace.export import BatchSpanProcessor
+
+def init(service_name, metric_port):
+ jaeger_exporter = JaegerExporter(
Review comment:
See the mail - I explained some details there. We alreeady have
'integrations" in airflow (separate compose files) and we have a mechanism to
enable/disable them in the dev environment - the docker-compose we are talking
about is the "Breeze" compose (which is Airflow's development environment and
it allows to start whole airflow with optional integrations (kerberos, mongo,
different databases etc.) so Jaeger (as server) will eventually have it's own
compose file (as all other integrations in Airflow Breeze). And yeah in airflow
we will only have (and also as an optional extra) jaeger agent (in OT
nomenclature - it is exporter) - and possibly few other exporters.
We even have task for that, to modularise the access. It's not super
straightforward though, as we'eve learned that with Gunicorn (and likely
Airflow worker model where we use forking), we need to add some extra
"exporter-specific" initialization after fork
(https://opentelemetry-python.readthedocs.io/en/latest/examples/fork-process-model/README.html)
but we will get there eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
