potiuk edited a comment on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-1009429873
> Those `.pyi` files get shipped with the providers, and we're now lying about what arguments are required for the sake of which example args we happen to use in the example dags? Not really. The .pyi files are not included in released providers (we only include .py files). They only impact 'example_dags" really - because those are the only "users" of the operators in airflow codebase. And what is really lying to our users are the `default_args` in this case, And yea, I also looked at the mypy for that (I actually hate we have to add .pyi files, but adding #tpeignores is I think even worse). And ye agree it's docuementation for plugins is non-existing. I think it's 'least' of the many evils we can have there * We could add #typeignores but they would make it part of our examples. I think very, very few of our users would use MyPY to verify their dags and adding those #typeignores in examples is generally bad idea because of noise (even if technically having them in examples is what would people end up with if they do use mypy). * We could add #typeignores on global level of the exampels (outside of the exampleinclude) but this way we won't be really properly testing the examples (and it's useful to run MyPy on them too But if you come up with a better idea - I am all ears :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
