potiuk commented on a change in pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#discussion_r782060062



##########
File path: scripts/ci/libraries/_spinner.sh
##########
@@ -1,55 +0,0 @@
-#!/usr/bin/env bash

Review comment:
       Rather than showing our animated spinner during the build I chose the 
option to simply show the buildkit output directly in the terminal. It's nice, 
colorful, animated and optimized to show only relevant information and take as 
little space as possible during the build. So we can remove the animated 
spinner now. 
   
   Also during the pre-commit  I opted to just show the warning that image is 
not updated rather that try to build it. User can build it when entering breeze 
or by (suggested) manual action. This simplifies interaction in pre-commit 
(there the difficulty is that the terminal there is difficult to get hold of).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to