khalidmammadov commented on a change in pull request #18590:
URL: https://github.com/apache/airflow/pull/18590#discussion_r782521989



##########
File path: tests/cli/commands/test_user_command.py
##########
@@ -45,18 +48,9 @@ def _set_attrs(self, app, dagbag, parser):
         self.dagbag = dagbag
         self.parser = parser
         self.appbuilder = self.app.appbuilder
-        self.clear_roles_and_roles()
+        delete_users(app)

Review comment:
       Int this test suite no new/test roles are created and hence no need to 
delete any roles. 
   Besides, `clear_roles_and_roles` function is used inside 
`test_role_command.py` suite where it only deletes specific users and roles and 
when new users are added or imported here they were not deleted and hence this 
PR cleans those traces.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to