Bowrna commented on issue #20740:
URL: https://github.com/apache/airflow/issues/20740#issuecomment-1010789046
Static Checks:
docker_engine_resources::check_all_resources
breeze::make_sure_precommit_is_installed
breeze::run_static_checks
Docker_engine_resources::check_all_resources:
Run the docker command in Python to determine the resource availability.
EXTRA_DOCKER_FLAGS
AIRFLOW_CI_IMAGE_WITH_TAG
This runs airflow ci image with tag with docker extra flags and entry point
as /bin/bash and executes the script in the path
/opt/airflow/scripts/in_container/run_resource_check.sh
This is an in_container script and after running docker it will be taken
care of. I have to work on starting the docker run command alone. These scripts
will be taken care of inside the docker container.
What's in the script?
Resources checked: Memory, CPU, Diskspace
Min Threshold of resources to run:
Memory : 4GB
CPU: 2
Disk available: 20 GB
Breeze::make_sure_precommit_is_installed
Check if pip or pip3 is in the path. Error out if not available. Then pip
install –upgrade pre-commit to install pre-commit.
path is updated with ~/.local/bin to the path in case pip is run outside of
virtualenv. (Do we have to do this step when converting to Python?, Also not
clear how this works, could you explain it to me?)
Breeze::run_static_checks
EXTRA_STATIC_CHECK_OPTIONS - Not sure where this is initialized. Could you
point me to where it’s initialized in code?
For all case, Pre commit run with EXTRA_STATIC_CHECK_OPTIONS
If static_check is mypy or flake8, then run Pre commit build first and then
run Pre commit run with static_check and EXTRA_STATIC_CHECK_OPTIONS
@potiuk I have done the first check in current breeze and picked the current
flow. Could you check and tell if my understanding is correct? Also can you
tell if have to follow the similar flow in Python too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
