potiuk commented on a change in pull request #20847:
URL: https://github.com/apache/airflow/pull/20847#discussion_r783749245
##########
File path: scripts/in_container/bin/run_tmux
##########
@@ -55,16 +55,16 @@ tmux send-keys -t 'Main' 'bash' C-m 'clear' C-m
tmux split-window -v
tmux select-pane -t 1
-tmux send-keys 'airflow scheduler' C-m
+tmux send-keys 'opentelemetry-instrument airflow scheduler' C-m
Review comment:
This is again tricky (a bit). This "opentelemetry-instriument" should
only be added when INTEGRATIONS environment variable will contain
"open-telemetry".
I think this should be something like:
```
COMMAND_PREFIX=""
if [[ " ${INTEGRATIONS[*]} " =~ " open-telemetry " ]]; then
COMMAND_PREFIX="opentelemetry-instrument"
fi
````
And then:
```
tmux send-keys "${COMMAND_PREFIX} airflow scheduler" C-m
```
(The " instead of ' are important)
But you will have to test it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
