ashb commented on a change in pull request #20743:
URL: https://github.com/apache/airflow/pull/20743#discussion_r784867350



##########
File path: airflow/models/baseoperator.py
##########
@@ -207,6 +207,7 @@ def apply_defaults(self: "BaseOperator", *args: Any, 
**kwargs: Any) -> Any:
 
             result = func(self, **kwargs, default_args=default_args)
             # Store the args passed to init -- we need them to support 
task.map serialzation!
+            kwargs.pop('task_id', None)

Review comment:
       Oh right I remember the problem now. Because we end up calling 
apply_defaults multiple times (once for each class in the MRO) task_id gets 
added in to kwargs for the `super().__init__(**kwargs)` call, so this del here 
is to make sure it doesn't get stored in partial kwargs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to