potiuk commented on issue #20739:
URL: https://github.com/apache/airflow/issues/20739#issuecomment-1013716604
> Why the args are passed after `--` though there is `--` prefixing the
option? @potiuk
The `--` is a way to indicate parameters passed directly to underlying tool
- at that time we did not want to define all the parameters as "build-docs"
command parameters so we passed them through directly to the build-docs.sh
script.
This is the typical/standard way of passing parametrs as pass -through to
underlyig command. The parameters before `--` are interpreted by the `./breeze
build-docs` command and the parameter after `--` are pased to the
./build-docs.sh script executed under-the-hood (via "${@}").
In the original breeze I did not want to explode even more the number of
options - that's why it was done this way. But in the new Breeze. We should
define those parameters as "./breeze build-docs` command parameters so that we
can get them auto-completeable.
So in the new Breeze2 it should be:
`./Breeze2 build-docs --package-filter ....` (See the ./build-docs.sh script
and the parameters it takes).
I actually think about even more consolidation of those commands but I will
formalize and propose it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
