[
https://issues.apache.org/jira/browse/AIRFLOW-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843165#comment-16843165
]
ASF GitHub Bot commented on AIRFLOW-4537:
-----------------------------------------
BasPH commented on pull request #5301: [AIRFLOW-4537] Remove the mkdir_p
function in favour of native Python pathlib
URL: https://github.com/apache/airflow/pull/5301
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4537
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Was trying to cleanup configuration.py and noticed this `mkdir_p` function
which seems to come straight from https://stackoverflow.com/questions/600268.
This functionality is now supported by native Python with pathlib, which is
also explained in the same post:
```python
pathlib.Path("/tmp/path/to/desired/directory").mkdir(parents=True,
exist_ok=True)
```
This PR removes `mkdir_p` in favour of pathlib.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cleanup the mkdir_p function
> ----------------------------
>
> Key: AIRFLOW-4537
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4537
> Project: Apache Airflow
> Issue Type: Sub-task
> Reporter: Bas Harenslak
> Assignee: Bas Harenslak
> Priority: Major
>
> configuration.mkdir_p seems to come straight from
> [https://stackoverflow.com/a/600612.]
> Now with Python 3.5, we have this functionality native. From the same post:
> {{pathlib.Path("/tmp/path/to/desired/directory").mkdir(parents=True,
> exist_ok=True)}}
> Remove the custom mkdir_p function and replace by pathlib. Will also resolve
> some imports to configuration, just for mkdir_p.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
