ashb commented on a change in pull request #20743:
URL: https://github.com/apache/airflow/pull/20743#discussion_r786199495
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -658,7 +694,9 @@ def deserialize_operator(cls, encoded_op: Dict[str, Any])
-> BaseOperator:
setattr(op, k, v)
for k in op.get_serialized_fields() - encoded_op.keys() -
cls._CONSTRUCTOR_PARAMS.keys():
- setattr(op, k, None)
+ # TODO: refactor deserialization of BaseOperator and
MappedOperaotr (split it out), then check could go away.
Review comment:
```suggestion
# TODO: refactor deserialization of BaseOperator and
MappedOperaotr (split it out), then check
# could go away.
```
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -658,7 +694,9 @@ def deserialize_operator(cls, encoded_op: Dict[str, Any])
-> BaseOperator:
setattr(op, k, v)
for k in op.get_serialized_fields() - encoded_op.keys() -
cls._CONSTRUCTOR_PARAMS.keys():
- setattr(op, k, None)
+ # TODO: refactor deserialization of BaseOperator and
MappedOperaotr (split it out), then check could go away.
Review comment:
```suggestion
# TODO: refactor deserialization of BaseOperator and
MappedOperaotr (split it out), then check
# could go away.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
