ashb commented on a change in pull request #20935:
URL: https://github.com/apache/airflow/pull/20935#discussion_r787678986
##########
File path: airflow/providers/amazon/aws/operators/eks.py
##########
@@ -281,29 +282,31 @@ class EksCreateNodegroupOperator(BaseOperator):
def __init__(
self,
cluster_name: str,
- nodegroup_subnets: List[str],
+ nodegroup_subnets: Union[List[str], str],
nodegroup_role_arn: str,
- nodegroup_name: Optional[str] = DEFAULT_NODEGROUP_NAME,
+ nodegroup_name: str = DEFAULT_NODEGROUP_NAME,
create_nodegroup_kwargs: Optional[Dict] = None,
aws_conn_id: str = DEFAULT_CONN_ID,
region: Optional[str] = None,
**kwargs,
) -> None:
self.cluster_name = cluster_name
- self.nodegroup_subnets = nodegroup_subnets
self.nodegroup_role_arn = nodegroup_role_arn
self.nodegroup_name = nodegroup_name
self.create_nodegroup_kwargs = create_nodegroup_kwargs or {}
self.aws_conn_id = aws_conn_id
self.region = region
+ if isinstance(nodegroup_subnets, str):
+ self.nodegroup_subnets = cast(List,
literal_eval(nodegroup_subnets))
+ else:
+ self.nodegroup_subnets = nodegroup_subnets
Review comment:
Oh yes we are ` nodegroup_subnets="{{
dag_run.conf['nodegroup_subnets'] }}",`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
