ashb commented on a change in pull request #20987:
URL: https://github.com/apache/airflow/pull/20987#discussion_r788814428
##########
File path: Dockerfile
##########
@@ -438,21 +438,23 @@ RUN apt-get update \
COPY scripts/docker/install_mysql.sh /scripts/docker/install_mssql.sh
/scripts/docker/
# fix permission issue in Azure DevOps when running the scripts
-RUN chmod a+x /scripts/docker/install_mysql.sh && \
- /scripts/docker/install_mysql.sh prod && \
- chmod a+x /scripts/docker/install_mssql.sh && \
- /scripts/docker/install_mssql.sh && \
- adduser --gecos "First Last,RoomNumber,WorkPhone,HomePhone"
--disabled-password \
- --quiet "airflow" --uid "${AIRFLOW_UID}" --gid "0" --home
"${AIRFLOW_USER_HOME_DIR}" && \
+RUN chmod a+x /scripts/docker/install_mysql.sh \
+ && sync \
+ && /scripts/docker/install_mysql.sh prod \
+ && chmod a+x /scripts/docker/install_mssql.sh \
+ && sync \
Review comment:
Perhaps?
```suggestion
RUN chmod a+x /scripts/docker/install_mysql.sh
/scripts/docker/install_mssql.sh \
&& sync \
&& /scripts/docker/install_mysql.sh prod \
```
(Either way avoiding two `sync`s probably worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
