ashb commented on a change in pull request #20945:
URL: https://github.com/apache/airflow/pull/20945#discussion_r789505506



##########
File path: airflow/models/baseoperator.py
##########
@@ -1718,8 +1615,11 @@ def __repr__(self) -> str:
 
     deps: Iterable[BaseTIDep] = attr.ib()
     operator_extra_links: Iterable['BaseOperatorLink'] = ()
-    params: Union[ParamsDict, dict] = attr.ib(factory=ParamsDict)
-    template_fields: Iterable[str] = attr.ib()
+    template_fields: Collection[str] = attr.ib()
+    template_ext: Collection[str] = attr.ib()
+
+    weight_rule: str = attr.ib()
+    priority_weight: int = attr.ib()

Review comment:
       We have a different problem.
   
   ```
    'partial_kwargs': {'executor_config': {<Encoding.TYPE: '__type'>: 
<DagAttributeTypes.DICT: 'dict'>, <Encoding.VAR: '__var'>: {'dict': 
{<Encoding.TYPE: '__type'>: <DagAttributeTypes.DICT: 'dict'>, <Encoding.VAR: 
'__var'>: {'sub': 'value'}}}},
                       'priority_weight': 10},
    'priority_weight': 10,
   ```
   
   It's in there twice, so you probaly want to exclude weight_rule, 
priority_weight and trigger_rule from being serialized, as they are already in 
partial kwargs.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to