eladkal commented on a change in pull request #21003:
URL: https://github.com/apache/airflow/pull/21003#discussion_r789677056
##########
File path: airflow/providers/google/cloud/transfers/s3_to_gcs.py
##########
@@ -21,9 +21,13 @@
from airflow.exceptions import AirflowException
from airflow.providers.amazon.aws.hooks.s3 import S3Hook
-from airflow.providers.amazon.aws.operators.s3_list import S3ListOperator
from airflow.providers.google.cloud.hooks.gcs import GCSHook, _parse_gcs_url,
gcs_object_is_directory
+try:
+ from airflow.providers.amazon.aws.operators.s3 import S3ListOperator
+except ImportError:
+ from airflow.providers.amazon.aws.operators.s3_list import S3ListOperator
Review comment:
It is more user friendly. I just mentioned that this is the first time
we do that...
On the other hand we have so many deprecated classes/functions/params right
now supporting all of them is not that easy. Maybe we should consider some
cleanup. Google provider for example had several major releases without
removing deprecated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
