potiuk commented on a change in pull request #21020:
URL: https://github.com/apache/airflow/pull/21020#discussion_r789934037
##########
File path: tests/www/api/experimental/test_dag_runs_endpoint.py
##########
@@ -97,12 +97,8 @@ def test_get_dag_runs_success_with_state_no_result(self):
# Create DagRun
trigger_dag(dag_id=dag_id, run_id='test_get_dag_runs_success')
- response = self.app.get(url_template.format(dag_id))
- assert 200 == response.status_code
- data = json.loads(response.data.decode('utf-8'))
-
- assert isinstance(data, list)
- assert len(data) == 0
+ with pytest.raises(ValueError):
Review comment:
I have a slight doubt about this one. This is "technically" breaking
change with the experimental API, but one that should be very welcomed by any
user. So I am tempted to leave it like that (I would treat it as a bugfix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
