kaxil commented on issue #5173: AIRFLOW-4295. Make comparison of `method` case insensitive in HttpHook URL: https://github.com/apache/airflow/pull/5173#issuecomment-493773005 @karan5291 I have to revert this commit from master as Travis failed with the following error: ``` [33m======================================================================[0m [33m46) ERROR: test_hook_with_method_in_lowercase (tests.hooks.test_http_hook.TestHttpHook)[0m [33m----------------------------------------------------------------------[0m [0m Traceback (most recent call last):[0m [34m.tox/py35-backend_mysql-env_docker/lib/python3.5/site-packages/requests_mock/mocker.py[0m line [1m[36m230[0m[0m in [36minner[0m return func(*args, **kwargs) [34m/usr/lib/python3.5/unittest/mock.py[0m line [1m[36m1157[0m[0m in [36mpatched[0m return func(*args, **keywargs) [34mtests/hooks/test_http_hook.py[0m line [1m[36m144[0m[0m in [36mtest_hook_with_method_in_lowercase[0m self.get_lowercase_hook.run('v1/test', data=data) [34mairflow/hooks/http_hook.py[0m line [1m[36m129[0m[0m in [36mrun[0m prepped_request = session.prepare_request(req) [34m.tox/py35-backend_mysql-env_docker/lib/python3.5/site-packages/requests/sessions.py[0m line [1m[36m462[0m[0m in [36mprepare_request[0m hooks=merge_hooks(request.hooks, self.hooks), [34m.tox/py35-backend_mysql-env_docker/lib/python3.5/site-packages/requests/models.py[0m line [1m[36m313[0m[0m in [36mprepare[0m self.prepare_url(url, params) [34m.tox/py35-backend_mysql-env_docker/lib/python3.5/site-packages/requests/models.py[0m line [1m[36m381[0m[0m in [36mprepare_url[0m raise InvalidURL(*e.args) ``` Can you fix it and raise a new PR?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
