potiuk commented on pull request #20886: URL: https://github.com/apache/airflow/pull/20886#issuecomment-1019613855
> @potiuk we have docker resource check for many breeze commands, for build-docs too. Do we have to run that docker command and then run the build-doc specific command? Yeah. Let's run it manually when we need it. There will be few commands that are interactive where just telling the users disk space or memory is too low might be really useful as the errors when you run out the the disk or memory might be super-confuising. > Also I tried to print the dry run docker command, as shown in attached screenshot. > Here for docker command, the EXTRA_DOCKER_FLAGS is passed( Where the mount happens) before running the docker command(both for resource check and build-docs). We have to include that as general function that decides to mount all file / select file depending upon the flag. After that run the docker command via subprocess in python. Am i right in understanding? Perfect understanding - this looks great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
