jedcunningham commented on a change in pull request #20864:
URL: https://github.com/apache/airflow/pull/20864#discussion_r791086198
##########
File path: chart/values.schema.json
##########
@@ -1979,6 +1979,45 @@
"x-docsSection": "Jobs",
"additionalProperties": false,
"properties": {
+ "command": {
+ "description": "Command to use when running create user
job (templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": null
+ },
+ "args": {
+ "description": "Args to use when running create user job
(templated).",
+ "type": [
+ "array",
+ "null"
+ ],
+ "items": {
+ "type": "string"
+ },
+ "default": [
+ "bash",
+ "-c",
+ "exec \\\nairflow {{ semverCompare \">=2.0.0\"
.Values.airflowVersion | ternary \"users create\" \"create_user\" }} \"$@\"",
+ "--",
+ "-r",
+ "{{ .Values.webserver.defaultUser.role }}",
+ "-u",
+ "{{ .Values.webserver.defaultUser.username }}",
+ "-e",
+ "{{ .Values.webserver.defaultUser.email }}",
+ "-f",
+ "{{ .Values.webserver.defaultUser.firstName }}",
+ "-l",
+ "{{ .Values.webserver.defaultUser.lastName }}",
+ "-p",
+ "{{ .Values.webserver.defaultUser.password }}"
+ ]
Review comment:
Yeah, our docs is "easy", but artifacthub uses the schema alone, e.g:
https://artifacthub.io/packages/helm/apache-airflow/airflow?modal=values-schema&path=workers.affinity
With fresh eyes, we probably should be removing "See values.yaml" instead of
adding more.
And good callout on the params being rough... It does indeed need some tlc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
