jhtimmins commented on pull request #19963: URL: https://github.com/apache/airflow/pull/19963#issuecomment-1020807513
This is a sensible change, and looks like it was supported in the original version of `UserRemoteUserModelView` in Flask Appbuilder. https://github.com/dpgaspar/Flask-AppBuilder/blob/985b1b7c1d77d38e667199573455a4a3b6f40ac9/flask_appbuilder/security/views.py#L286 It shouldn't be necessary to modify `_class_permission_name` or `class_permission_name_mapping` though, since those values remain unchanged from the base class. It may be tricky to test though. @kosteev or @lwyszomi can one of y'all verify that the change works as intended and that you can actually add a new user and then log in with that user? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
