potiuk commented on issue #4937: [AIRFLOW-4116] Multi-staging includes CI image [Step 2/3] URL: https://github.com/apache/airflow/pull/4937#issuecomment-493862639 Hey @Fokko, @gerardo @mik-laj (@BasPH / @kaxil as well) - I'd love the final round of reviews for this one. Since Travis is now much more stable, I am back onto replacing the docker image for tests with the one here. I fixed all the regular tests in #4938 and they are running for a while already - stable every time I rebase. The only remaining are kubernetes tests which I am going to fix shortly I hope. I have done the last round of fixes/updates: * shellcheck corrections to the scripts (thanks @mik-laj for the hints) * re-introduced mysql instead of mariadb (one of the export/import tests was failing with mariadb client) * i found a way to retain the usage of --chown at COPY so the image now is a bit smaller (previously I changed the ownership which caused duplication of source layer). I now need to merge this Step 2 to master, so that I can configure DockerHub to build 3.5 and 3.6 images so that I can switch to using them instead of my private images during the tests. Then the 3rd commit will. I think It makes sense to run tests for both 3.5 and 3.6 but I am open to only running it for one of those (preferably 3.6). Once the tests are working I think we can also cherry-pick and backport the very same changes to v1-10-* branch and have separate CI images for the v1.10- series (I was testing it for python 2.7 as well). But I would do that only after we merge it fully to master.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
