Bowrna commented on a change in pull request #20848:
URL: https://github.com/apache/airflow/pull/20848#discussion_r792274620
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -276,6 +281,22 @@ def change_config(python, backend, cheatsheet, asciiart):
console.print(f'[blue]Backend cached_value {backend}')
+@option_verbose
[email protected](name="static-check")
[email protected]('-t', '--type', type=click.Choice(PRE_COMMIT_LIST),
multiple=True)
+def static_check(verbose: bool, type: Tuple[str]):
+ if check_package_installed('pre_commit'):
+ command_to_execute = ['pre-commit', 'run']
+ for single_check in type:
+ command_to_execute.append(single_check)
+ command_to_execute.append(EXTRA_STATIC_CHECK_OPTIONS)
+ output = run_command(
Review comment:
yes it will work, but I am just worried about the order of unknown
options in tuple. but as tuple preserves the insertion order it should work.
@potiuk
Also there may be error cases where user sets the flag and doesn't pass the
file name. In that case, it will fail after running the precommit command and
not by validating the incoming commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
