potiuk edited a comment on issue #20974:
URL: https://github.com/apache/airflow/issues/20974#issuecomment-1022444970


   > 1. Keep the current behaviour (`**context` only works with `use_dill`), 
and add a friendly message (perhaps also some documentation) when the user does 
this to reject the callable at DAG-parse time. `**context` will no longer work, 
and users not wishing to use dill will have to explicitly name the arguments 
(e.g. `def my_func(ds):` instead).
   
   > 2. Automatically exclude non-serialisable objects from when `use_dill` is 
not set. This makes `**context` automatically work, but may introduce 
additional confusion when the user actually tries to access things in it.
   
   I am for using dill=True. We are not going to endorse using **context 
directly, especially with the TaskFlow API it's more convenient to use directly 
context field. It would be fantastic (Not sure if that can be done or maybe 
works already) if we could get the Context field names auto-complete'able in 
this case. And we do not leave the user without solution - add use_dill=True 
and it should work.
   
   I think we should also make sure that everywhere in our docs where we could 
"endorse" it, we should remove it and maybe add the explanation. Happy to take 
a look at the docs and try to find out all places and update them, if we agree 
to that.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to