[
https://issues.apache.org/jira/browse/AIRFLOW-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844026#comment-16844026
]
ASF GitHub Bot commented on AIRFLOW-4545:
-----------------------------------------
StewartW commented on pull request #5306: AIRFLOW-4545 - Update Flask
AppBuilder to 1.12.4
URL: https://github.com/apache/airflow/pull/5306
Update flask appbuilder to take advantage of bug fix in security/
manager.py - this fix allows Github / Github Enterprise OAuth users to
auto register. It was previously failing due to expecting 'userinfo' to
contain more than just an email address.
Flask-AppBuilder 1.12.4 change log:
github.com/dpgaspar/Flask-AppBuilder/tree/v1.12.4#package-version
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- Updating package version for Flask-Appbuilder to take advantage of
[this](https://github.com/dpgaspar/Flask-AppBuilder/commit/7d80f7e855eb9ae7fa3725054af07593f34c986f)
bug-fix
### Tests
- [ ] Minor release of 3rd party dependency
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Github Enterprise OAuth auto registration fails due to bug in
> Flask-AppBuilder Lib.
> -----------------------------------------------------------------------------------
>
> Key: AIRFLOW-4545
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4545
> Project: Apache Airflow
> Issue Type: Bug
> Components: authentication, webserver
> Affects Versions: 1.10.3
> Reporter: Stewart Wallace
> Assignee: Stewart Wallace
> Priority: Minor
>
> Registration of users via Github Enterprise fails due to a mishandling of the
> userinfo in the Security manager
> See
> [https://github.com/dpgaspar/Flask-AppBuilder/blob/v1.12.3/flask_appbuilder/security/manager.py#L841]
> It's fixed with v.1.12.4
> See:
> [https://github.com/dpgaspar/Flask-AppBuilder/blob/v1.12.4/flask_appbuilder/security/manager.py#L841]
> I'd like to upgrade this if at all possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
