potiuk opened a new pull request #21219:
URL: https://github.com/apache/airflow/pull/21219
We used to have two options in our CI - one was to build the
images in the "build" step and pull them in "ci/tests" steps, the
other was to build the images in "ci/tests" steps as a backup,
in case the build/ci workflows has some problems. It's likely been
a year or more when we did not have to use the other workflow and
since switching to GitHub Registry as cache it became extremely
stable, which means that we can remove the option where the
images might be build "on the spot" in the CI/tests steps.
That involves few clarifications:
* we can split `prepare` scripts into separate `pull` and `build`
ones
* the steps with `Prepare` name (which was - either pull or build)
can use proper name (either Pull or Build)
* GITHUB_REGISTRY_WAIT_FOR_IMAGE variable and corresponding
BUILD_IMAGES_OVERRIDE and debug secret to enable "build in CI"
flow can be removed
* documentation is updated
This will also allow to easier implement the equivalent steps
in the "CI & Breeze" override project, as the steps will be now
possible to replace with corresponding breeze's build-image/
pull_image functions and calls.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
