[
https://issues.apache.org/jira/browse/AIRFLOW-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844509#comment-16844509
]
ASF GitHub Bot commented on AIRFLOW-4549:
-----------------------------------------
dima-asana commented on pull request #5308: [AIRFLOW-4549] skipped tasks should
be ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4549
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
this PR updates wait_for_downstream dependency to be satisfied for tasks
that are skipped. This is desirable because
(a) depends_on_past, which this is interacts with, allows skipped tasks
(b) documentation for wait_for_downstream mentions it is to avoid resource
conflicts, which are de facto avoided when a task is skipped
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
TaskInstanceTest.test_wait_for_downstream
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> wait_for_downstream does not respect skipped tasks
> --------------------------------------------------
>
> Key: AIRFLOW-4549
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4549
> Project: Apache Airflow
> Issue Type: Bug
> Components: scheduler
> Reporter: Dima Kamalov
> Assignee: Dima Kamalov
> Priority: Major
>
> See
> [http://mail-archives.apache.org/mod_mbox/airflow-dev/201609.mbox/%3ccaheep7utgpjvkgww9_9n5fupnu+pskf3rmbvxugk5dxb6bh...@mail.gmail.com%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
