jedcunningham commented on a change in pull request #21255:
URL: https://github.com/apache/airflow/pull/21255#discussion_r796859257
##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -44,17 +44,17 @@
class ElasticsearchTaskHandler(FileTaskHandler, ExternalLoggingMixin,
LoggingMixin):
"""
ElasticsearchTaskHandler is a python log handler that
- reads logs from Elasticsearch. Note logs are not directly
- indexed into Elasticsearch. Instead, it flushes logs
+ reads logs from Elasticsearch. Note that Airflow does not handle the
indexing
+ of logs into Elasticsearch. Instead, Airflow flushes logs
into local files. Additional software setup is required
- to index the log into Elasticsearch, such as using
+ to index the logs into Elasticsearch, such as using
Filebeat and Logstash.
- To efficiently query and sort Elasticsearch results, we assume each
+ To efficiently query and sort Elasticsearch results, this handler assumes
each
log message has a field `log_id` consists of ti primary keys:
`log_id = {dag_id}-{task_id}-{execution_date}-{try_number}`
Log messages with specific log_id are sorted based on `offset`,
Review comment:
```suggestion
Log messages are sorted based on `offset`,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
