dima-asana commented on a change in pull request #5308: [AIRFLOW-4549] skipped
tasks should be ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#discussion_r285941732
##########
File path: airflow/models/taskinstance.py
##########
@@ -509,14 +509,15 @@ def are_dependents_done(self, session=None):
TaskInstance.dag_id == self.dag_id,
TaskInstance.task_id.in_(task.downstream_task_ids),
TaskInstance.execution_date == self.execution_date,
- TaskInstance.state == State.SUCCESS,
+ TaskInstance.state.in_([State.SKIPPED, State.SUCCESS]),
Review comment:
(this is the only line of non-test code that is changed -- the rest is
either testing or documentation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
