feluelle commented on a change in pull request #5305: [AIRFLOW-986] HiveCliHook
ignores 'proxy_user' value in a connection's extra parameter
URL: https://github.com/apache/airflow/pull/5305#discussion_r286203958
##########
File path: airflow/hooks/hive_hooks.py
##########
@@ -122,11 +122,13 @@ def _prepare_cli_cmd(self):
template = utils.replace_hostname_pattern(
utils.get_components(template))
- proxy_user = "" # noqa
+ proxy_user = conn.extra_dejson.get('proxy_user', "") # noqa
if conn.extra_dejson.get('proxy_user') == "login" and
conn.login:
proxy_user =
"hive.server2.proxy.user={0}".format(conn.login)
elif conn.extra_dejson.get('proxy_user') == "owner" and
self.run_as:
Review comment:
```suggestion
elif proxy_user == "owner" and self.run_as:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
