dossett commented on issue #4064: AIRFLOW-3149 Support dataproc cluster 
deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#issuecomment-494544592
 
 
   Good news @OmerJog , I added a test that work @fenglu-g.  The bad news is 
that it uses a pattern that @DanSedov retired in his PR, namely inspecting the 
log messages.  I wasn't able to find another to verify that a cluster delete 
was attempted because my `_execute_delete` method in the hook is a 
`@staticmethod`.   Per my earlier comment, I may have undone some of Dan's work 
with this patch, so I'll revisit the test if there's a better way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to