potiuk commented on pull request #21294: URL: https://github.com/apache/airflow/pull/21294#issuecomment-1029207368
> @potiuk @jhtimmins what was the reason to move FAB's BaseSecurityManager to airflow? Becz even if we sync methods and attributes between FAB and Airflow to fix these issues, we would be required to limit Flask-Appbuilder to current version i.e 3.4.4 I believe, the main reasons are that the new UI will not need FAB but uses the security model. so the idea is that at **some** point in time (we do not know when) we might want to remove FAB as dependency. And yeah. I think it is a good point that we should immediately limit FAB to 3.4.4 and in the future deliberatly move to new versions with conscious mind. I think this is what you should really do in this PR so in setup.cfg set `==3.4.4` for FAB - precisely for the reasons you described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
