[
https://issues.apache.org/jira/browse/AIRFLOW-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845244#comment-16845244
]
ASF GitHub Bot commented on AIRFLOW-4554:
-----------------------------------------
dossett commented on pull request #5310: [ AIRFLOW-4554] Test for sudo command,
add some other test docs
URL: https://github.com/apache/airflow/pull/5310
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses [Airflow Jira
4554](https://issues.apache.org/jira/browse/AIRFLOW-4554) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
Shell script tests for the `sudo` command and only uses it if present.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: The bash script is untested.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [] Passes `flake8` (N/A - no python change)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> run_unit_tests.sh uses sudo unconditionally
> -------------------------------------------
>
> Key: AIRFLOW-4554
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4554
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Aaron Dossett
> Assignee: Aaron Dossett
> Priority: Major
>
> The run_unit_tests.sh script includes a sudo command:
>
> [https://github.com/apache/airflow/blob/master/run_unit_tests.sh#L65]
> However, one of the recommended methods for running unit tests locally is to
> create a docker container and that container lacks the sudo command. The
> script should only sudo if sudo exists.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
