Bowrna edited a comment on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1029581924
> That's simple. The global constants should contain the variables that do not change when parameters change. The dataclass should be used when you have a "calculated" value which depends on the parameters that you passed to the "breeze" command. > Actually that was one of the difficulty with Bash - because you can hardly distinguish those - env variable is an env variable and whether it is "unchangeable" or whether it has been calculated on-the-fly using passed parameters it is hard to tell. The Dataclass is our chance to distinguish between those two cases. yes, I could understand this part, but figuring out if the variable remains constant / varies depending on 'parameters' passed to breeze command is the part where I am confused. Say example `USE_AIRFLOW_VERSION ` does it have to go to global constants or dataclass. Does the user can set this value / does it have to remain constant? How do I figure out that? @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
