[ 
https://issues.apache.org/jira/browse/AIRFLOW-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Lamblin updated AIRFLOW-4556:
------------------------------------
    Description: 
As far as I can tell, when AIRFLOW-1512 was closed it added the operator 
without adding the required {{virtualenv}} package into {{setup.py}}.

[https://github.com/apache/airflow/blob/master/airflow/operators/python_operator.py#L380]

I know tests were added, and presume they pass, but that's probably because the 
package exists on the test harnesses and most users' python deployment.

If you move to Python 3 though, and start working with the built in {{venv}} 
module instead, as recommended generally, or if you use a very bare Python 2, 
then this operator doesn't work as intended.

Correct me if I'm wrong.

  was:
As far as I can tell, when AIRFLOW-1512 was closed it added the operator 
without added the required {{virtualenv}} package into \{{setup.py}}.

[https://github.com/apache/airflow/blob/master/airflow/operators/python_operator.py#L380]

I know tests were added, and presume they pass, but that's probably because the 
package exists on the test harnesses and most users' python deployment.

If you move to Python 3 though, and start working with the built in {{venv}} 
module instead, as recommended generally, or if you use a very bare Python 2, 
then this operator doesn't work as intended.

Correct me if I'm wrong.


> The PythonVirtualenvOperator was added without its required `virtualenv` 
> package
> --------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4556
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4556
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.0, 1.10.1, 1.10.2, 1.10.3
>            Reporter: Daniel Lamblin
>            Priority: Minor
>
> As far as I can tell, when AIRFLOW-1512 was closed it added the operator 
> without adding the required {{virtualenv}} package into {{setup.py}}.
> [https://github.com/apache/airflow/blob/master/airflow/operators/python_operator.py#L380]
> I know tests were added, and presume they pass, but that's probably because 
> the package exists on the test harnesses and most users' python deployment.
> If you move to Python 3 though, and start working with the built in {{venv}} 
> module instead, as recommended generally, or if you use a very bare Python 2, 
> then this operator doesn't work as intended.
> Correct me if I'm wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to