potiuk commented on a change in pull request #21382:
URL: https://github.com/apache/airflow/pull/21382#discussion_r800547202
##########
File path: docs/apache-airflow/concepts/dags.rst
##########
@@ -363,6 +368,60 @@ However, this is just the default behaviour, and you can
control it using the ``
* ``none_skipped``: No upstream task is in a ``skipped`` state - that is, all
upstream tasks are in a ``success``, ``failed``, or ``upstream_failed`` state
* ``always``: No dependencies at all, run this task at any time
+.. note::
Review comment:
I think this should be a separate chapter. It appears a bit "out of the
blue" here and it's not entirely clear why it is here.
I think it could be an "Example of implementing watcher pattern with rules"
(or something like that). also I think it should be accompanied with a nice
graph image for the DAG and some "overview" on that showing which rules are
which - the visual representation of it will make world of a difference here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
