ephraimbuddy commented on pull request #21214:
URL: https://github.com/apache/airflow/pull/21214#issuecomment-1031427778


   
   
   
   
   > With main plus "active_runs-1" or with this branch plus "active_runs-1"?
   > 
   > Main plus "active_runs-1" - the manually changed DagRun state leads to a 
hang for me (with `AIRFLOW__SCHEDULER__MIN_FILE_PROCESS_INTERVAL=86400`). This 
branch plus "active_runs-1" - the manually changed DagRun state works fine.
   
   It still works for me in main, not sure why. I will suggest we implement 
`active_runs-1` and look at fixing it when the state is manually changed. 
   We can also create a boolean column on DagModel and instead of nullifying 
next_dagrun_create_after, we nullify the column. That way, we don't need to 
calculate the column again. We would just set the new column when 
max_active_runs is reached and unset it when dagrun finishes running or are 
marked manually as failed.
   That together with `active_runs-1` at lines 1088 and 1062 will be a better 
fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to