potiuk commented on pull request #20326: URL: https://github.com/apache/airflow/pull/20326#issuecomment-1032734137
Why Intentionally? It does not look like this was intentional, because it has been called in the operator (in case of error, but it was). It could be that there was another mistake in the operator that called this method - but this did seem like a missing method that is used elsewhere? https://github.com/apache/airflow/blob/837ff7ed10d440efe1f5e5149821d9bb2df4f383/airflow/providers/google/cloud/operators/dataproc_metastore.py#L138 ``` except HttpError as err: if err.resp.status not in (409, '409'): raise self.log.info("Backup %s already exists", self.backup_id) backup = hook.get_backup( project_id=self.project_id, region=self.region, service_id=self.service_id, backup_id=self.backup_id, retry=self.retry, timeout=self.timeout, metadata=self.metadata, ) return Backup.to_dict(backup) ``` What do you think is the right fix @lwyszomi ? Should id be replaced with something else here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
