dstandish commented on a change in pull request #21385:
URL: https://github.com/apache/airflow/pull/21385#discussion_r801806736
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -1514,6 +1515,8 @@ def insert_job(
characters. If not provided then uuid will be generated.
:param project_id: Google Cloud Project where the job is running
:param location: location the job is running
+ :param is_async: specify whether to insert job in asynchronous mode
+ :type is_async: bool
Review comment:
```suggestion
```
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -1498,6 +1498,7 @@ def insert_job(
job_id: Optional[str] = None,
project_id: Optional[str] = None,
location: Optional[str] = None,
+ is_async: bool = False,
Review comment:
i think we should rename `is_async`... it doesn't seem quite right
because you are not _describing_ something (i.e. whether it _is_ async or not),
but rather _instructing_ the func whether to make the call in an async way or
not (so maybe `use_async` would be better).
but there's a suggestion from @uranusjr to use `nowait` which i think is
probably better because it avoids the word `async` which is a bit fraught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
