ashb commented on a change in pull request #21476:
URL: https://github.com/apache/airflow/pull/21476#discussion_r803273023
##########
File path: airflow/www/static/js/tree/dagRuns/Bar.jsx
##########
@@ -34,53 +34,76 @@ import { callModalDag } from '../../dag';
const DagRunBar = ({
run, max, index, totalRuns, containerRef,
-}) => (
- <Box position="relative">
- <Flex
- height="100px"
- alignItems="flex-end"
- justifyContent="center"
- pb="2px"
- px="3px"
- onClick={() => {
- callModalDag({ execution_date: run.executionDate, dag_id: run.dagId,
run_id: run.runId });
- }}
- >
- <Tooltip
- label={<DagRunTooltip dagRun={run} />}
- hasArrow
- portalProps={{ containerRef }}
- placement="top"
- openDelay={100}
+}) => {
+ let highlightHeight = '100%';
+ if (containerRef && containerRef.current) {
+ const table = containerRef.current.getElementsByTagName('table')[0];
+ highlightHeight = table.offsetHeight - 53; // subtract the height of the
duration axis labels
Review comment:
Hmmm magic numbers. Is there some way we can not hard code the height of
another element here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
