ashb commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r803520412
##########
File path: airflow/models/xcom.py
##########
@@ -458,8 +469,8 @@ def clear(
return query.delete()
@staticmethod
- def serialize_value(value: Any):
- """Serialize Xcom value to str or pickled object"""
+ def serialize_value(value: Any, key=None, task_id=None, dag_id=None,
execution_date=None, run_id=None):
Review comment:
We shouldn't have execution_date on main anymore, and we should add
map_index now.
```suggestion
def serialize_value(*, value: Any, key: str, task_id: str, dag_id: str,
run_id: str, map_index: int = -1):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
