ashb commented on a change in pull request #21489:
URL: https://github.com/apache/airflow/pull/21489#discussion_r803548113
##########
File path: airflow/utils/helpers.py
##########
@@ -258,8 +257,7 @@ def build_airflow_url_with_query(query: Dict[str, Any]) ->
str:
import flask
view = conf.get('webserver', 'dag_default_view').lower()
- url = flask.url_for(f"Airflow.{view}")
- return f"{url}?{parse.urlencode(query)}"
+ return flask.url_for(f"Airflow.{view}", **query)
Review comment:
Turns out URL for handles url prams and everything else gets set as
query params, so the fix was easy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
