ashb commented on a change in pull request #21495:
URL: https://github.com/apache/airflow/pull/21495#discussion_r806081503
##########
File path: airflow/models/taskinstance.py
##########
@@ -1836,7 +1838,7 @@ def get_template_context(
params.update(task.params)
if conf.getboolean('core', 'dag_run_conf_overrides_params'):
self.overwrite_params_with_dag_run_conf(params=params,
dag_run=dag_run)
- validated_params = task.params = params.validate()
+ validated_params = params.validate()
Review comment:
I forget the error, but setting it here was giving some kind of error (I
think from it being set _twice_ on the same in-memory object, once in the
supervisor, and once in the actual runner.)
So I took the approach that `get_*` should never have any sideffects!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
