milton0825 commented on a change in pull request #5321: [AIRFLOW-4565]
instrument celery executor
URL: https://github.com/apache/airflow/pull/5321#discussion_r287507900
##########
File path: airflow/executors/base_executor.py
##########
@@ -129,6 +129,19 @@ def heartbeat(self):
Stats.gauge('executor.queued_tasks', num_queued_tasks)
Stats.gauge('executor.running_tasks', num_running_tasks)
+ self.trigger_tasks(open_slots)
+
+ # Calling child class sync method
+ self.log.debug("Calling the %s sync method", self.__class__)
+ self.sync()
+
+ def trigger_tasks(self, open_slots):
+ """
+ Trigger tasks. This function is overwritten in CeleryExecutor
Review comment:
I think it is fine that you don't mention `This function is overwritten in
CeleryExecutor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
