eladkal commented on a change in pull request #21551:
URL: https://github.com/apache/airflow/pull/21551#discussion_r806680629
##########
File path: airflow/providers/postgres/example_dags/example_postgres.py
##########
@@ -70,8 +70,9 @@
BETWEEN SYMMETRIC DATE '{{ params.begin_date }}' AND DATE '{{
params.end_date }}';
""",
params={'begin_date': '2020-01-01', 'end_date': '2020-12-31'},
Review comment:
I don't think it's wrong. The code references to params by
`params.begin_date`,` params.end_date`
`parameters` is to pass the assignment to sqlalchemy engine (which means you
will not see the full rendered query in render tab)
Though I would say that params are not really needed here as the dates are
static... so they can be just placed in the SQL directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
